search

matthewrudy / memoist

ActiveSupport::Memoizable with a few enhancements
MIT License
920 stars 99 forks source link

Make Memoist.escape_punctuation compatible with MRI 2.7 #82

Closed casperisfine closed 4 years ago

casperisfine commented 5 years ago

In https://bugs.ruby-lang.org/issues/16150 MRI merge an experimental feature that makes Symbol#to_s return a frozen string.

So unless that experiment is reverted before release, escape_punctuation need to handle string.to_s being potentially frozen.

@matthewrudy

casperisfine commented 5 years ago

The CI failures seem to be due to outdated travis config. Other than that it's green.

yahonda commented 5 years ago

Hi, I'd like this pull request reviewed because this change should address one of Rails CI failure reported at https://buildkite.com/rails/rails/builds/64100#92ed9e75-c005-42a2-af7d-64b2997f0436/984-1452

sebjacobs commented 4 years ago

I'm sorry for the delay but my brother, @matthewrudy, recently passed away.

According to recent activity on the original ruby issue 1: it looks like there might be plans to revert the experiment for the time being, however I am happy to help with getting this change merged regardless.

casperisfine commented 4 years ago

I'm sorry for the delay but my brother, @matthewrudy, recently passed away.

I'm sorry for your loss.

casperisfine commented 4 years ago

As for CI failures @unasuke opened https://github.com/matthewrudy/memoist/pull/84.

sebjacobs commented 4 years ago

Thanks @casperisfine. This looks good.

casperisfine commented 4 years ago

Thanks for the merge.

Is there anything you'd like included in the next release that I can help with?

ghiculescu commented 3 years ago

For those who just saw this (like me), 0.16.1 and up include this fix.