matthewrudy / memoist

ActiveSupport::Memoizable with a few enhancements
MIT License
920 stars 99 forks source link

Fix for Ruby 3 keyword arg splatting change #92

Open jasonperrone opened 3 years ago

jasonperrone commented 3 years ago

This is how I addressed the Ruby 3 keyword args splatting change incompatibility as mentioned here: https://bugs.ruby-lang.org/issues/14183.

Tests pass. Up to you if you want to accept this change.

stokarenko commented 2 years ago

Hey @sebjacobs, is there any chance to get it released? I'm ready to improve this PR a bit as per my comment above )

pboling commented 2 years ago

ping! I am starting to use this on a Ruby 3 project now. Until this is fixed I'll only be able to use memoist on methods without arguments

patbl commented 2 years ago

@pboling https://github.com/matthewrudy/memoist/issues/88#issuecomment-918506434

pboling commented 3 months ago

FYI: Added this alert to the new memoist repo

[!IMPORTANT]

Recommendation

Consider using MemoWise instead, as it is maintained, fully tested, provides thread safety guarantees, and is much, much faster.

Other Alternatives

In case you need a tool with this feature set that is currently maintained, check out:

[!TIP]
Seriously though, read the important note above.

[!WARNING]
If you must continue - be aware that this is unmaintained software.