matthewrudy / memoist

ActiveSupport::Memoizable with a few enhancements
MIT License
920 stars 99 forks source link

Ruby 3 support #93

Closed honzasterba closed 1 year ago

honzasterba commented 2 years ago

I have taken the changes from https://github.com/matthewrudy/memoist/pull/92 fixed up the code and added tests and CI runs for Ruby 3 and 3.1

The solution for ruby3 kwargs is to add the hash of passed kwargs in its array form the the cache ivar.

patbl commented 2 years ago

It probably won't be merged soon: https://github.com/matthewrudy/memoist/issues/88#issuecomment-918506434

evanbattaglia commented 1 year ago

Thanks for doing this! Maybe we should make this against https://github.com/memoist/memoist ? Or possibly @sebjacobs would be able to approve this?

honzasterba commented 1 year ago

@evanbattaglia moved to https://github.com/memoist/memoist/pull/2

pboling commented 3 months ago

FYI: Added this alert to the new repo

[!IMPORTANT]

Recommendation

Consider using MemoWise instead, as it is maintained, fully tested, provides thread safety guarantees, and is much, much faster.

Other Alternatives

In case you need a tool with this feature set that is currently maintained, check out:

[!TIP]
Seriously though, read the important note above.

[!WARNING]
If you must continue - be aware that this is unmaintained software.