search

matthewsamuel95 / ACM-ICPC-Algorithms

Algorithms used in Competitive Programming
2.1k stars 1.27k forks source link

Is there a fault in heap_sort? #1036

Open Jiangluyu opened 4 years ago

Jiangluyu commented 4 years ago

I have prudently went through the source code, but I found a problem(maybe) when I use the following data: {42, 20, 17, 13, 28, 14, 23, 15}, I think there are other WRONG data like this. In my opinion, that's because in the last sort loop, the arr is 28 42 23 20 17 15 14 13, and the heap left is 28 42, so it does not satisfy the condition to swap 28 & 42, but actually 28 42 is not in the right order.

anishsingh935 commented 3 years ago

can I fix this issues please