matthewscharles / instrument-maker

A framework for making digital instruments with sensors, driven by a need to improve access.
http://www.instrumentmaker.org/
GNU General Public License v3.0
18 stars 5 forks source link

confirm sample folder path and demo content, update paths in help files #40

Open alexmlucas opened 4 years ago

alexmlucas commented 4 years ago

The file path of samples might need to be updated in the restructure branch now that their location has moved. I've changed im.keypress-help.pd already but other files need to be updated, e.g. im.debounce-help.pd.

If you're settled on the new sample location, I'm happy to change these as I come across them.

matthewscharles commented 4 years ago

thanks for doing this. rather than going through individually, I've taken to working through find and replace in atom

I'm moving the sounds folder into im.objects for now. it doesn't make as much sense in the folder structure but as a release it'll need to live in the same folder

the deeper issue here is that declare does not extend to sound files https://github.com/pure-data/pure-data/issues/234 (at least not with readsf~), which will also make it difficult for the user to import their own sounds without adding paths.

this wasn't such a problem in the original context of packaging patches for Bela, but I would consider switching over to a buffer-based solution so that we can use [soundfiler]

I guess that for the nime workshop you might want to work out a sample folder as a constraint in the workshop, and/or we could agree on some better samples to include!!

alexmlucas commented 4 years ago

Great, thanks Charles. Just noticed that the file path to string.aif hasn't been updated in im.debounce-help. Not sure if this slipped through the net as it's an .aif file?