search

matthewscharles / instrument-maker

A framework for making digital instruments with sensors, driven by a need to improve access.
http://www.instrumentmaker.org/
GNU General Public License v3.0
18 stars 5 forks source link

Keypress objects broken on Windows #54

Open alexmlucas opened 4 years ago

alexmlucas commented 4 years ago

Seems to be a broader issue affecting newer additions to the IM library.

While objects such as im.keypress can be created on Windows, they do not work i.e. the output remains at a constant value of 1. The abstractions of these objects cannot be opened either.

alexmlucas commented 4 years ago

Using Pd-0.50-2.

alexmlucas commented 4 years ago

There are likely two separate issues here. Pd seems to save the position of the window in abstractions. As I was using a second monitor when patching these, the abstractions do open but off-screen when using a single monitor. Might only be an issue on Windows. Will fix this now.

alexmlucas commented 4 years ago

im.keypress/im.snapshot not changing state seems to be a separate issue. Only a problem when using the IM library from a downloaded zip file rather than installing through git - I think!

alexmlucas commented 4 years ago

I think this second issue was just down to dsp not being switched on.

matthewscharles commented 4 years ago

re window position yes for sure, it's an issue with help files as well. I'll add this to the compilation/tidy-up script which currently deletes the font size

re keys, I wonder if key & keyup would have the same issues. keyname was just much more elegant for taking the abstraction apart (@davedarch pointed me to this)

I can fire up windows and linux tonight/tomorrow

dsp is turned on automatically within im.speaker. I don't see why we couldn't put in a loadbang to turn dsp on for any objects that rely on a signal (e.g. im.snapshot)