search

matthewswallace / openfl-tilelayer

41 stars 23 forks source link

Test fails to render bitmap on neko #4

Open drkibitz opened 11 years ago

drkibitz commented 11 years ago

This is with the latest from github (sorry for not checking before my last issue).

screen shot 2013-10-14 at 5 30 17 pm

drkibitz commented 11 years ago

I should also mention I am running Haxe 3.0.1, Neko 2.0.0, Mac OS 10.8.5.

And probably more importantly, the dev versions of hxcpp, nme, openfl, openfl-native, openfl-tools

Might be a compatibility change in the latest one of those libs :/

drkibitz commented 11 years ago

You also might notice that the screen shot is not a build directly from the test project, but I can confirm that the same thing happens there.

drkibitz commented 11 years ago

Ok I double checked by running this example https://github.com/jgranick/nme-bunnymark TileTest.hx does work when targeting neko on the same environment, so I'm leaning more toward that the issue is somewhere in tilelayer.

drkibitz commented 11 years ago

I may have found the issue, still debugging though. This https://github.com/matthewswallace/openfl-tilelayer/blob/master/haxelib/aze/display/TileLayer.hx#L96 line fails on Neko. A failed cast does not result in null on Neko.

drkibitz commented 11 years ago

Yep that was it, do you want a pull request for a one line fix? Just change this line https://github.com/matthewswallace/openfl-tilelayer/blob/master/haxelib/aze/display/TileLayer.hx#L93 to:

#if (flash||js||neko)