search

matthewtrask / elephpant-traders

Code for elephpanttrade.com
http://elephpanttrade.com/#/
6 stars 3 forks source link

Fix Add Elephpant button on wishlist #55

Closed cookieguru closed 6 years ago

cookieguru commented 6 years ago

On the Wishlist page, the Add Elephpant button is nonfunctional. An <a> tag with a href attribute cannot be a child of <button>. While most browsers support href on <button> it's not in the spec and thus we'll just render the link as an <a> and not a <button> and add the appropriate classes (and the role attr because that's how Bootstrap rolls).

matthewtrask commented 6 years ago

nice, thanks for catching that!