search

matthewvilhauer / racing-game

0 stars 0 forks source link

feedback #5

Open jlopker opened 8 years ago

jlopker commented 8 years ago

Technical Requirements:

Creativity:

Code Quality:

hilava commented 8 years ago

Hi Juliana This is feedback on mat's racing game not mine right? Hila On Apr 5, 2016 3:03 PM, "jlopker" notifications@github.com wrote:

Technical Requirements:

  • You met all the technical requirements!
  • Good frequent commits with detailed messages

Creativity:

  • I really like the concept! Nice work on the bidirectional movement!

Code Quality:

  • Your code is very DRY and well commented, nice work! I also appreciate your thorough README.
  • More Bootstrap integration! Your button could easily be styled with Bootstrap.
  • You followed good variable naming conventions
  • The movePlayer() function indentation is a little funky

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/matthewvilhauer/racing-game/issues/5