Introduce hardware_name as configuration option

matthewwall / weewx-interceptor

weewx driver that intercepts web traffic from internet 'bridge' devices such as Acurite Access, ObserverIP, OS LW30x, LaCross GW1000U, FineOffset GW1000

GNU General Public License v3.0

105 stars 44 forks source link

Introduce hardware_name as configuration option #97

Closed ThomDietrich closed 2 years ago

ThomDietrich commented 3 years ago

Hey there, this PR adds the ability to name your weather station model name/type instead of just using the device_type which doesn't say much. The hardware name is important for users to be able to form an subjective opinion about accuracy and quality of sensor readings.

Before:

After:

Resolves #96

For testing:

wget -O weewx-interceptor.zip https://codeload.github.com/ThomDietrich/weewx-interceptor/zip/refs/heads/patch-1

ThomDietrich commented 2 years ago

Hey, this is now even more useful with the improvement in the online map: https://github.com/weewx/website/issues/4

Please consider this change. Thanks

Ruxton commented 2 years ago

@matthewwall super useful feature here, can we get this merged in?

matthewwall commented 2 years ago

yes on this. i will include this with the pile of other fixes now that i've got weewx-sdr a bit more under control.

ThomDietrich commented 2 years ago

Hey, any news on this PR? Cheers

ThomDietrich commented 2 years ago

Hey Matthew! I can see that there was not a lot of movement in your repos the last 1-2 years. There are a bunch of forks with valuable contributions but the project is in a stale state. You did great work with these weewx addons and judging by stars and forks they are quite popular. Would you be interested to add additional contributors to the projects, maybe move them to an organization with likeminded people even? Happy to be part of the group!

CC @Ruxton @nifoc @erudita @hoetzgit

Thanks for consideration! :)

KruseLuds commented 2 years ago

Hey Matthew! I can see that there was not a lot of movement in your repos the last 1-2 years. There are a bunch of forks with valuable contributions but the project is in a stale state. You did great work with these weewx addons and judging by stars and forks they are quite popular. Would you be interested to add additional contributors to the projects, maybe move them to an organization with likeminded people even? Happy to be part of the group!

CC @Ruxton @nifoc @erudita @hoetzgit

Thanks for consideration! :)

Ditto

matthewwall commented 2 years ago

i hear you! i am planning some weewx time next week to merge all of these wonderful contributions. my apologies for letting this get so stale - after the merges i will be happy to add some collaborators on this project so that we don't end up with lots of forks and so that my schedule does not block progress.