search

matthewwall / weewx-sdr

weewx driver for software-defined radio
GNU General Public License v3.0
114 stars 74 forks source link

Resolve #79 - new model name and wind fields in RTL-433 V20 #88

Closed mitchins closed 2 years ago

mitchins commented 4 years ago

As discussed in #79 the RTL-433 V20 (what's in ubuntu-focal) has changed some of the model names and wind fields. This solves it for the WH1080, there are already some PRs for other stations like: https://github.com/matthewwall/weewx-sdr/pull/85/commits/5ee971d29bd00d034ae9ee7ef3471fb2fefa7f9a

They seem to be mutually exclusive in that the field names are isolated under the model class, additionally I only have this station so cannot check anything else I change.

These changes have been tested inside whew 4.1.1 with a Hassio plugin I've been created and everything captures fully.

mitchins commented 4 years ago

Tagging @matthewwall

mitchins commented 4 years ago

Looks Good. Differences are similar to some changes need to be applied for Fineoffset-WH65B that I will submit in separate PR.

Thanks, since I didn't have that model to test I couldn't vouch for doing it.

vittorio88 commented 4 years ago

No prob! Thank you for documenting the issue to begin with!

For reference, separate PR for Fineoffset-WH65B is here https://github.com/matthewwall/weewx-sdr/pull/92

mitchins commented 4 years ago

@vittorio88 who can mere this?

matthewwall commented 2 years ago

the changes in this MR were incorporated some time ago in the FOWHx080Packet