matthewwardrop / formulaic

A high-performance implementation of Wilkinson formulas for Python.
MIT License
347 stars 25 forks source link

Add the missing transforms to bring parity with patsy / R. #18

Open matthewwardrop opened 4 years ago

matthewwardrop commented 4 years ago

Formulaic's support for stateful transforms is underutilised. Over the coming couple of weeks I'll be adding support in for the missing transforms, aiming to be compatible with patsy and R implementations.

lorentzenchr commented 2 years ago

Is the above list up to date? I'm curious if I could be of any help.

matthewwardrop commented 2 years ago

Hi @lorentzenchr !

Obviously I didn't get to this in the timeline intimated. COVID has led to some changes in various trajectories, including with me heading back to Australia (a big transition given I have four kids). My plan is still to get to this, but you can feel free to explore implementing cr, cc and te if you are interested. I am far more opinionated about the implementation of C.

Note that it was my intention to write these from scratch after learning the mathematics behind them, as I did the others. This allowed me to write things with high performance in mind, and avoid copyright issues.

lorentzenchr commented 2 years ago

Hope you and your family are fine. In my opinion, C is the most important of all. I'll have a look at the spline basis, let's see.

lorentzenchr commented 2 years ago

I'd be interested in your opinions about C.

matthewwardrop commented 2 years ago

Hi @lorentzenchr ; sorry... lost the thread here a bit. I've implemented support for different contrast matrices now in #70. Feel free to take a look :).

bashtage commented 1 week ago

I have started working on cc and cr as these are needed for statsmodels.