No way to retrieve and reuse drop_index when na_action='drop'

matthewwardrop / formulaic

A high-performance implementation of Wilkinson formulas for Python.

MIT License

345 stars 25 forks source link

No way to retrieve and reuse drop_index when na_action='drop' #195

Closed andrejmuhic closed 5 days ago

andrejmuhic commented 1 week ago

Thank you for writing this library. I have added pull request that enables this, I would appreciate your insight as I am not sure what is the best way to handle this. Also maybe I missed something. https://github.com/matthewwardrop/formulaic/pull/194

matthewwardrop commented 5 days ago

@andrejmuhic I've merged in support for this as described in #197 :). Let me know if this doesn't work for you.

andrejmuhic commented 1 day ago

@matthewwardrop Thank you for this. I think this will work nicely. I will test it out soon. I am not a big fan of passing results by modifying arguments in python but your solution seems more pragmatic.