search

matthewwithanm / pilkit

Utilities and processors built for, and on top of PIL
BSD 3-Clause "New" or "Revised" License
196 stars 54 forks source link

Packaging issue with the 'tests/' directory #14

Closed saimn closed 10 years ago

saimn commented 10 years ago

Hi, as your tests directory is included in the distributed tarball as a top-level package, it is installed in python's site-packages (which can cause conflicts with other packages doing the same thing):

~ $ ls /usr/lib/python3.4/site-packages/tests
assets/  __init__.py  __pycache__/  test_processors.py  test_utils.py  utils.py

One option would be to exclude it from the distributed tarball, and the other option is to move it to pilkit.tests.

matthewwithanm commented 10 years ago

Ugh, yeah. Sorry about that. If you can put together a PR I'll merge ASAP.

saimn commented 10 years ago

Oh, that's a quick answer :). I'll try to do that soon, what option do you prefer ?

matthewwithanm commented 10 years ago

Will just removing the __init__.py from tests do the job?

saimn commented 10 years ago

Yep it seems to work, otherwise I would propose something like https://dpaste.de/6Gmp

matthewwithanm commented 10 years ago

Alright, this should be fixed in 1.1.11. Thanks!

saimn commented 10 years ago

Thanks !