matthewwithanm / pilkit

Utilities and processors built for, and on top of PIL
BSD 3-Clause "New" or "Revised" License
196 stars 54 forks source link

passing upscale option to thumbnail processor #3

Closed petry closed 11 years ago

matthewwithanm commented 11 years ago

Thanks @petry! Do you think we should default upscale to False for this one? Also, I wonder if we should matte it (so that the image dimensions match those provided to the processor) by default.

Let me know your thoughts!

petry commented 11 years ago

I think None is better, this way we preserve the default value of processors inside this class. Maybe in future, we need another processor inside this class and his default value is True.

anyway, I add more tests to fully cover this method