search

matthewwithanm / pilkit

Utilities and processors built for, and on top of PIL
BSD 3-Clause "New" or "Revised" License
196 stars 54 forks source link

Add ColorOverlay processor #4

Closed dulacp closed 8 years ago

dulacp commented 11 years ago

Hi,

First thanks for your great work! That's neat.

Those two little processors were very useful for one of my project, it allows us to overlay a solid color mask over the original image. Glad to hear your thoughts about it.

Cheers

matthewwithanm commented 11 years ago

Thanks so much for the kind words, @dulaccc! Sorry I didn't get to this right away, but I've been super busy.

A couple questions/observations about your new processors:

  1. Was there a specific reason you used ImageColor.getrgb? That only takes color strings right? IMO that would limit the functionality some, as well as introducing an inconsistency with the rest of the library.
  2. I wonder if the ColorOverlay would be more useful if you could provide different blend modes…
  3. Can you explain the DominantColorOverlay processor a bit? I can't really think of a use case for that and I wonder if perhaps it wasn't something very specific to your project.

Thanks again for the PR!

dulacp commented 8 years ago

I feel sorry to have let this PR without any update from my end. Your comment was very pertinent.

Cheers

vstoykov commented 8 years ago

Hi @dulaccc I'm new maintainer of the project. This PR is here for a long time.

At the end this PR is not very big and 5 commits are too much. Can you squash your commits to only one commit?

Thanks

dulacp commented 8 years ago

Of course I can, doing it right now

vstoykov commented 8 years ago

Thanks.