matthewwithanm / pilkit

Utilities and processors built for, and on top of PIL
BSD 3-Clause "New" or "Revised" License
196 stars 54 forks source link

require unittest.mock instead of mock #54

Closed pgajdos closed 1 year ago

pgajdos commented 2 years ago

Could you please consider to use unittest.mock instead of mock, as fallback at least?

dvzrv commented 1 year ago

Hi! I'm packaging this project for Arch Linux and would also very much like to see this happen. Is there a particular reason to still offer support for python 2.7? Only with python >= 3.3 unittest.mock is available and it's possible to replace mock (entirely). If backwards compatibility should still be guaranteed, it would need to be done via a conditional import.

In general it would be advisable to not support versions outside of the officially supported Python versions though, as that guarantees an easier handling of these types of dependencies (by removing them).

dvzrv commented 1 year ago

@vstoykov @matthewwithanm ping

vstoykov commented 1 year ago

Fixed in #71