search

matthiaaas / express-file-routing

Flexible file-based routing for Express (like Next.js + additional features)
https://www.npmjs.com/package/express-file-routing
MIT License
85 stars 13 forks source link

Add support Windows #5

Closed Rysakov1986 closed 3 years ago

Rysakov1986 commented 3 years ago

Hello! Okay, the analogue was removed where I asked to add my ideas, then you can add them here? ))

Please replace/add from ":id.ts" to "$id.ts"

Thanks!

matthiaaas commented 3 years ago

What do you think of a Next.js like workaround with wrapping [] e.g. [id].ts?

Rysakov1986 commented 3 years ago

It`s good, i thought to offer this option)

matthiaaas commented 3 years ago

Alright, I'll wait for @mathec-x Pull Request, which will include all the changes you already raised in his repo so I don't need to reimplement those solutions. So sorry for this inconvenience, hopefully we'll see a PR shortly!

Rysakov1986 commented 3 years ago

Is @mathec-x ready to cooperate, did he say anything about it?

matthiaaas commented 3 years ago

Yes, I reached out to him already and he said he's preparing a PR at the moment. Hopefully we'll see his changes merged into this repo by tomorrow.

PaulMaly commented 3 years ago

@matthiaaas I hope that @mathec-x will be added as a core team member of this repo (if he wants of course)? I believe it will be fair and help boost maintainability of this nice project.

Rysakov1986 commented 3 years ago

@PaulMaly How are your hopes? )))

matthiaaas commented 3 years ago

I would be willing to make him a core contributor, but first of all he needs to respect some fundamental open source fairplay rules. He again released another copy of this package on his own GitHub & NPM without any credit or need for doing so.