search

matthias-bs / BresserWeatherSensorTTN

Bresser 5-in-1/6-in-1/7-in-1 868 MHz Weather Sensor Radio Receiver based on ESP32 and RFM95W/SX1276 - sends data to a LoRaWAN Network (e.g. The Things Network)
MIT License
23 stars 9 forks source link

LoraData too long #18

Closed DL4AAS closed 1 year ago

DL4AAS commented 1 year ago

Hi,

if some sensors are not available and commented out, the data sent to LoRaWAN is too long.

The reason is obvious: // Schedule transmission if (! myLoRaWAN.SendBuffer( loraData, sizeof(loraData), ...

Change sizeof(loraData) to encoder.getLength() should give a better result.

Regards, Jens

matthias-bs commented 1 year ago

Hi,

absolutely! I introduced this a while ago, but accidentally overwrote it (0c32fbc17d6068ed13020dd9cc7e7bfbfe4beaf4).

Fixed in 855d50fec896e22fc19a2b6a13e2f7e76dcac4ab.

Thanks for reporting!

Best regards, Matthias

matthias-bs commented 1 year ago

Hi,

can this issue be closed?

Best regards Matthias

DL4AAS commented 1 year ago

Hi Matthias,

Yes, thanks.

The rain counter User Byte 12, as YouTube thought. Byte 16 is different, but I have only one type of sensor..

Jens

Matthias Prinke @.***> schrieb am Do., 5. Jan. 2023, 10:27:

Hi,

can this issue be closed?

Best regards Matthias

— Reply to this email directly, view it on GitHub https://github.com/matthias-bs/BresserWeatherSensorTTN/issues/18#issuecomment-1371974437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEFGXX6TZA2AA2GV7GXPJPTWQ2HXHANCNFSM6AAAAAAS4KFKOM . You are receiving this because you authored the thread.Message ID: @.***>