matthias-mayr / skiros2_pyrobosim_lib

Skills and knowledge representation for a set of pyrobosim problems
9 stars 1 forks source link

Autoparameterization does not run again if a parameter has been set by a previous skill #2

Closed matthias-mayr closed 1 week ago

matthias-mayr commented 2 months ago

@p-rosit: This is an example directly related to the workshop.

Setup

To get there, it's time to work with the workshop repos: https://github.com/ros-wg-delib/roscon24-workshop

git clone --recurse-submodules https://github.com/ros-wg-delib/roscon24-workshop.git
docker compose build
docker compose run base

Inside the container start the world

ros2 run delib_ws_worlds run --ros-args -p problem_number:=1

Start SkiROS2 with this:

ros2 launch skiros2_pyrobosim_lib main.launch.py

Running the skill

These parameter settings on a newly started world should work: image

Nice to see. But there's a catch: To get it to work, I had to introduce this parameter: https://github.com/matthias-mayr/skiros2_pyrobosim_lib/blob/f8eed45e02ef93c0214f3dd2791f7d7b6b4a1e74/skiros2_pyrobosim_lib/pyrobosim_solutions.py#L13

and use it here: https://github.com/matthias-mayr/skiros2_pyrobosim_lib/blob/f8eed45e02ef93c0214f3dd2791f7d7b6b4a1e74/skiros2_pyrobosim_lib/pyrobosim_solutions.py#L35 which is not really how it should work

matthias-mayr commented 1 month ago

I circumvented this by explicitly setting the StartLocation in problem 1: 670146eefed4f772e99fb315761fdbe5667c26b1

However, that's still only a workaround

matthias-mayr commented 1 week ago

I moved this issue to the SkiROS2 main repo since it's not specific to this repo: https://github.com/RobotLabLTH/skiros2/issues/116