search

matthias4217 / jukebox-ultra-nrv

Multi-user jukebox for LAN use
https://gitlab.com/club-jeux-int/jukebox-ultra-nrv
3 stars 3 forks source link

Removing the currently playing song stops the jukebox completely #53

Closed PaulDance closed 5 years ago

PaulDance commented 5 years ago

When removing the currently playing song from the jukebox using the corresponding black cross button, the entry is removed yes, but firstly the song does not really stop:

capture-2

and secondly also, the entire server seems to simply exit without any error message:

capture-3

while the youtube embeded video still runs and is still interactive but without any sound produced though.

matthias4217 commented 5 years ago

I can reproduce it yes. There was a nasty segfault (#43) that I thought I had fixed. I guess it's back ! The embedded video is loaded client-side, so it will stay no matter what the server status is.

PaulDance commented 5 years ago

The embedded video is loaded client-side, so it will stay no matter what the server status is.

Don't you think having a client-side embedded video messes things up a bit ? Because from my experience using the jukebox so far, it's a bit confusing and adds instability to the whole functionality ?

matthias4217 commented 5 years ago

The client-side part is quite separate from the rest, and is managed with JQuery and Youtube iframe API. We only fetch the current video ID and and time of the mpv progression to sync the video. Thus I don't think it is too much of a problem. I'm not the strongest proponent for this solution but other people do want to see a video. Most of the instability is caused server-side by my usage of flask, sorry. Normally latest version mkIII-0.6.9 should be stable enough.