search

matthiasbock / BooleSim

Systems biology tool: Boolean network simulator
http://matthiasbock.github.io/BooleSim
11 stars 6 forks source link

libSBGN.js is not readable #33

Open matthiasbock opened 11 years ago

matthiasbock commented 11 years ago

I only just noticed that libSBGN.js is a "compressed" JavaScript file. This does not comply with the idea of open source. We definitely should have a readable version there.

We can think of preparing a packed version with everything in one file ("BooleSim-1.0.html5"), but the source code should be clean.

matthiasbock commented 11 years ago

https://github.com/chemhack/libSBGN.js

chaitan3 commented 11 years ago

compressed Javascript files are not against open source. The compression is done to improve browser parsing speed. And all professional websites(even open source ones) use compressed js files to improve performance. For example the jquery libs are compressed. In our README we can give links to the original developers repo.

matthiasbock commented 11 years ago

jQuery is a special case, because it's a big project. libSBGN is a rather small one. We should really keep a readable copy. Especially since we may want to modify it.

I am not against packing in general to improve performance, but e.g. right now I am struggling to enhance the GINML import code, because I can't read the libSBGN source.

chaitan3 commented 11 years ago

Whenever I had a problem in libSBGN.js I just directly referred to chemhack's source code. It is way easier to read his code in it's development form than to read a single compiled file. Anyways if you still need such a single compiled file, checkout his source and do "ant compile-simple" and replace libSBGN.js with the generated file. I cannot do it currently as I do not have the tools and I have a bandwidth cap :(.