Address CMD check notes

matthiasgomolka / simfinapi

Makes 'SimFin' data (https://simfin.com/) easily accessible in R.

19 stars 4 forks source link

Address CMD check notes #27

Closed superchordate closed 3 years ago

superchordate commented 3 years ago

I was curious why 0.2.0 hasn't been published to CRAN yet, so I ran CMD check --as cran. These two items came up as NOTES so I figured I'd fix them: README.html coming through the build, and non-standardized URL format for CRAN.

These shouldn't prevent publishing though. @matthiasgomolka can you share the reason why 0.2.0 hasn't been published to CRAN? Seems like it's ready to go and the instructions on github don't work with 0.1.0 (no function sfa_set_cache_dir).

Thanks!

matthiasgomolka commented 3 years ago

Hi and thanks for the PR. The reason why 0.2.0 is not on CRAN yet is my constrained time. I want to implement a solution for #6 before releasing the next version to CRAN and I plan to do so within the next 2 weeks. Then, I'll release the next CRAN version.