search

matthiasgomolka / simfinapi

Makes 'SimFin' data (https://simfin.com/) easily accessible in R.
19 stars 4 forks source link

Split `sfa_get_shares()` #33

Closed matthiasgomolka closed 1 year ago

matthiasgomolka commented 3 years ago

Right now, sfa_get_shares() has some arguments which apply only for specific types. This is confusing. Therefore, sfa_get_shares() should be split up into sfa_get_shares_common() and sfa_get_shares_wa().

This would mean that sfa_get_shares_common() would not need the arguments type, period, and fyear.

sfa_get_shares_wa() would not need the arguments start and end.

matthiasgomolka commented 1 year ago

Since I'm preparing for a majopr update to adapt simfinapi to the newly release API V3, I won't implement any new features for V2 any more.