search

matthiasgomolka / simfinapi

Makes 'SimFin' data (https://simfin.com/) easily accessible in R.
19 stars 4 forks source link

API v3 #53

Closed matthiasgomolka closed 8 months ago

matthiasgomolka commented 8 months ago

As mentioned in #51, the new API V3 is now mandatory. This PR accomodates for the respecting changes. This is a rather rough PR since not all features are fully tested and there might be other smaller issues.

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 25.20000% with 187 lines in your changes are missing coverage. Please review.

Project coverage is 20.44%. Comparing base (39c0de7) to head (8b3c49e).

Files Patch % Lines
R/sfa_load_statement.R 0.00% 53 Missing :warning:
R/sfa_load_shareprices.R 0.00% 48 Missing :warning:
R/utils.R 6.97% 40 Missing :warning:
R/sfa_load__shares_outstanding.R 0.00% 35 Missing :warning:
R/check_inputs.R 10.00% 9 Missing :warning:
R/zzz.R 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #53 +/- ## =========================================== - Coverage 92.71% 20.44% -72.28% =========================================== Files 13 10 -3 Lines 508 318 -190 =========================================== - Hits 471 65 -406 - Misses 37 253 +216 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.