matthiask / django-prose-editor

ProseMirror-based HTML editor for Django
https://django-prose-editor.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
90 stars 6 forks source link

Prose editor display can be improve on admin panel #7

Closed zft9xgy closed 1 month ago

zft9xgy commented 1 month ago

First, thank for create this, your work and dedication.

The prose editor is display like this in the admin panel:

Captura de pantalla 2024-07-18 a las 22 38 48

What i suggest is to set min-height and a margin-bottom to improve first look.

src/css/editor.css

.ProseMirror {
  /* 
 Existing attributes
*/
  min-height: 30vh;
}

.prose-editor {
 /* 
 Existing attributes
*/
  margin-bottom: 10px;
}

In my opinion this will display a better text box.

Captura de pantalla 2024-07-18 a las 23 11 47
matthiask commented 1 month ago

Hi

I agree it looks better in this example. However, if you have a help_text the margin is too large. Also, if you have several small text fields the min-height seems to large, respectively the small height looks just right to me:

image

Since this is something which can be easily achieved when implementing the editor I don't think I want to apply these changes to the default styles.

zft9xgy commented 1 month ago

Agree on that and the use cases. Thank four taking your time to response.

matthiask commented 1 month ago

Sure thing! Thanks for the suggestion.