matthiask / plata

Plata - the lean and mean Django-based Shop
https://plata-django-shop.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
197 stars 63 forks source link

refactored plata_tags, different product_list #37

Closed sbaechler closed 11 years ago

sbaechler commented 11 years ago

Implemented feedback on previous commits. Refactored module for less code duplication and renamed form_item_tc tag to form_item_terms. I did not see an alternative way of implementing this function without just writing the form code by hand.

The other change adresses the added context variable tax_included which allows to alter the display of the tax depending on it being included in the item price or not.

sbaechler commented 11 years ago

Commit 3 is a fix because form_errors displays an empty list if used on formsets even if there are no errors.

matthiask commented 11 years ago

A few of these have been cherry picked. Can you open new pull requests for any remaining features you'd like to merge?

Thanks!