search

matthiask / plata

Plata - the lean and mean Django-based Shop
https://plata-django-shop.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
197 stars 63 forks source link

Discount - get all eligible products #5

Closed scristian71 closed 11 years ago

scristian71 commented 13 years ago

Do you think it is OK to add to DiscountBase class a method to retrieve a list with product_variation and new price (after we apply discount). Or is a method to get a list with discounted products variations (without making an order)?

Thanks.

Cristian

matthiask commented 13 years ago

There is no such method yet. This would be a worthwhile addition to Plata though. Do you want to give it a shot?

scristian71 commented 13 years ago

Yes, I want. I fact I started something. I want to implement it as a method of DiscountBase that return a list of tuples (Product, DiscountedPrice) for applied discount. And also, it must be a method in Product that will return the discounted price, after applying all defined discounts. It is OK?

Cristian.

matthiask commented 13 years ago

Yes, I think that's correct.

matthiask commented 11 years ago

Closing this issue for now.