matthiaskoenig / fbc_curation

FROG analysis in python for the reproducibility of FBC models
https://runfrog.de
GNU Lesser General Public License v3.0
8 stars 2 forks source link

metadata fields #31

Closed bgoli closed 3 years ago

bgoli commented 4 years ago

Matthias, in your example I don't get:

"software.name": "fbc_curation" "solver.name": "cobrapy (glpk)"

What software are you talking about here, I would expect these to refer to the modelling software not the curator software:

"software.name": "cobrapy" "solver.name": "glpk"

To do what you want, the metadata needs to look look like this: { "curator.name": "fbc_curation", "curator.version": "0.1.1", "curator.url": "https://doi.org/10.5281/zenodo.3708271", "software.name": "cobrapy", "software.version": "0.1.1", "software.url": "https://doi.org/", "software.environment": "posix, Linux, 5.4.0-48-generic", "solver.name": "glpk", "solver.version": "0.20.0" "model.filename": "e_coli_core.xml", "model.md5": "4574760460afe9e1b3388dc15f354706", }

I'm fine with adding these new fields

matthiaskoenig commented 4 years ago

perfect, will update these fields with the next round of changes

matthiaskoenig commented 3 years ago

Closing this. Duplicate of information in #32.