search

matthiaskoenig / fbc_curation

FROG analysis in python for the reproducibility of FBC models
https://runfrog.de
GNU Lesser General Public License v3.0
8 stars 3 forks source link

Better filename for OMEX archive #74

Closed matthiaskoenig closed 2 years ago

matthiaskoenig commented 2 years ago

Use combination of model filename, hash and timestamp.

draeger commented 2 years ago

What to do if an archive contains more than just a model file? For instance, also SBGN with a part of the model visualized – such a file could then have a diverging name, e.g., central_carbon_metabolism.xml or similar. Would you give priority to SBML file or SED-ML?

matthiaskoenig commented 2 years ago

@draeger Could point. I am not completely sure how to handle things at the moment. Issues exist in general for archives with multiple models. I.e. for what models should the FROG report be generated (probably for all). But what naming convention should be used for the different output files. I have to think a bit more about this, but useres complained that the hash alone as filename is not very useful.

matthiaskoenig commented 2 years ago

No perfect solution for this. Adding a FROG_ prefix to the hash so that it is more clear that the omex is a FROG report.