search

matthiasmullie / minify

CSS & JavaScript minifier, in PHP. Removes whitespace, strips comments, combines files (incl. @import statements and small assets in CSS files), and optimizes/shortens a few common programming patterns.
https://matthiasmullie.github.io/minify/
MIT License
1.97k stars 309 forks source link

grid-template-columns (and possible others) get shortened wrongly #367

Open davidbehler opened 3 years ago

davidbehler commented 3 years ago

Possible duplicate of or at least related to #365.

Version used: 1.3.66

I have this class which basically splits a div in half: .split-half { display: grid; grid-template-columns: calc(50% - 1rem) calc(50% - 1rem); grid-column-gap: 2rem; } and after minifying it becomes .split-half { display: grid; grid-template-columns: calc(50% - 1rem); grid-column-gap: 2rem; } The second column value is removed and turns this into a very different layout.

I'm guessing this happens because the values for both columns are equal. If I change the definition to
.split-half { display: grid; grid-template-columns: calc(50% - 1rem) calc(50% - 1.1rem); grid-column-gap: 2rem; } it works and the definition is kept. Same for using repeat(2, calc(50% - 1rem)).

DIntriglia commented 3 years ago

Just ran into this problem as well. Any updates on a resolution?