advice for cache - Githubissues

Hello!

This is more a question/advice for security/fast way to cache than a problem. I see alot people looking for cache, so, sorry if this is a wrong place, but its nice to keep this documented here.

First i'm using gzip, so i done the workaround on htaccess

AddEncoding gzip .jsgz .cssgz
AddType application/x-javascript .jsgz
AddType text/css .cssgz

After that I redirect all css and js from /modules/ directory to my PHP

RewriteCond %{REQUEST_FILENAME} -f
RewriteRule ^modules/(.*\.(css|js))$ index.php?$1&param=minify

On my PHP, I:

get the QUERY_STRING to know css/js path
create md5 HASH from that name
verify if the filename exists into /cache/HASH folder
if not, ->gzip(HASH_FILENAME)
redirect to the new location with HEADER status 302

I think my logic is ok, but i'm in doubt if this redirect are ok

The browser target to /modules/css/global.css, i do the processes, save gziped file on /cache/css/526b0d2b64e1f1a76ebc41e457ca584e.cssgz and redirect with header funcion to this new path

On the second time, the browser target to /modules/css/global.css, and I redirect to /cache/css/526b0d2b64e1f1a76ebc41e457ca584e.cssgz with header function with status 302

Do you guys think this is a correct way to cache, or can we get some bether way?

The whole code

if ((isset($_GET['param'])) && ($_GET['param'] == "minify")) {

    // Get css/js filepath
    $_SERVER['QUERY_STRING'] = str_replace("&param=minify", "", $_SERVER['QUERY_STRING']);
    list($name) = explode('?', urldecode($_SERVER['QUERY_STRING']));
    $name = "modules/" . $name;

    // Verify the type
    $type = strtolower(pathinfo($name, PATHINFO_EXTENSION));

    // Verify the cache
    $cache_name = md5($name);
    $cache_file = APPLICATION_PATH . "/../public_html/cache/" . $type . "/" . $cache_name . "." . $type . "gz";
    if(file_exists($cache_file)) {
        header("Location: /cache/" . $type . "/" . $cache_name . "." . $type . "gz", TRUE, 302);
        exit();
    }

    // Minify
    if($type == "css") {
        $minifier = new \MatthiasMullie\Minify\CSS(APPLICATION_PATH . "/../" . PUBLIC_DIR . "/" . $name);
    }
    else {
        $minifier = new \MatthiasMullie\Minify\JS(APPLICATION_PATH . "/../" . PUBLIC_DIR . "/" . $name);
    }
    $minifier->gzip($cache_file);

    header("Location: /cache/" . $type . "/" . $cache_name . "." . $type . "gz", TRUE, 302);
    exit();
}

matthiasmullie / minify

advice for cache #396