search

matthiasmullie / minify

CSS & JavaScript minifier, in PHP. Removes whitespace, strips comments, combines files (incl. @import statements and small assets in CSS files), and optimizes/shortens a few common programming patterns.
https://matthiasmullie.github.io/minify/
MIT License
1.97k stars 309 forks source link

Waiting for the new version #412

Closed vanushwashere closed 1 year ago

vanushwashere commented 1 year ago

I encountered a performance loss on some websites because of Minifier, and after a little bit research I found out that there were many performance fixes on the master branch. Are you planning to release the new version?

vanushwashere commented 1 year ago

I checked that website with the version from the master branch and it still had a very big performance loss(like 20s instead of 1s). :(

matthiasmullie commented 1 year ago

Thanks for pointing this out - I had not realized I must've forgotten about the release when last landing changes. Release coming soon.

matthiasmullie commented 1 year ago

Done - released 1.3.71

vanushwashere commented 1 year ago

It's fixed the performance issues, but strange. I tested master branch yesterday and still had them. Anyway, thanks for the fast response and useful package. I was thinking, maybe adding some settings to bypass removing comments would be helpful for such cases. Would you like a PR ?

matthiasmullie commented 1 year ago

Alas; comments will need to be extracted either way - otherwise, comments that contain code (or stuff that looks like it) in them may affect the rest of the minification.

vanushwashere commented 1 year ago

Yeah, but I mean it might be helpful to skip some optimization in favor of overall speed and performance.