search

matthiasmullie / scrapbook

PHP cache library, with adapters for e.g. Memcached, Redis, Couchbase, APC(u), SQL and additional capabilities (e.g. transactions, stampede protection) built on top.
https://www.scrapbook.cash
MIT License
315 stars 27 forks source link

New exception for failed operations #23

Closed martin-georgiev closed 7 years ago

martin-georgiev commented 7 years ago

This PR shall provide a graceful way of handling failures by Memcached::getMulti. Previously only the happy path of Memcached::getMulti was covered. This makes it harder to debug in PHP before v7 as uncatchable error will be thrown.

Bonus: Slight improvements for the comment blocks, so NetBeans can parse them as normal phpDoc blocks.

codecov-io commented 7 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.19%. The diff coverage is 19.04%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #23     +/-   ##
========================================
- Coverage   84.29%   84.1%   -0.2%     
========================================
  Files          44      44             
  Lines        2726    2737     +11     
========================================
+ Hits         2298    2302      +4     
- Misses        428     435      +7
Impacted Files Coverage Δ
src/Adapters/Memcached.php 71.14% <19.04%> (-2.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a1ded...5da7981. Read the comment docs.

martin-georgiev commented 7 years ago

Excellent! Thanks for the collaboration :)