search

matthiasnoback / live-code-coverage

Generate code coverage reports on a live server
MIT License
116 stars 8 forks source link

Upgrade phpunit/php-code-coverage to 9.0 #15

Closed nreynis closed 4 years ago

nreynis commented 4 years ago

This package dependencies prevent upgrading to phpunit 9.3.
Being stuck with phpunit 9.2 is an issue because it also lock us away from PHP8.

matthiasnoback commented 4 years ago

Makes sense, can you make a PR?

nreynis commented 4 years ago

I tried to give it a shot, but there's major BC in php-code-coverage.
I'm not familiar with previous version, so I'll have to understand what each method was doing and how it maps to the new API. If I have some time I'll try to dig further, but I can't promise anything.

nreynis commented 4 years ago

Done!

matthiasnoback commented 4 years ago

Fixed by #16.

matthiasnoback commented 4 years ago

Thanks a lot Nicolas! I've added one other commit because I noticed that PHPUnit now has a FilterMapper that does the work of processing the files and directories etc. inside the config. So that saves us a few lines here.

matthiasnoback commented 4 years ago

By the way, I've released this as v1.4.0.