Closed kuczek closed 9 years ago
This is not Symfony Bundle so there should be no tests with different symfony versions. I assume you mean doctrine and i will test it with doctrine 2.2+
Ah yes, sorry about my mistake. You should still remove the branch alias from composer.json
. Then I think it's good to go!
Maybe better will be to change it to 0.4.x-dev?
I usually leave the branch alias out, because it is (in the case of this small library) one extra thing you have to take care of when releasing a new feature. So I'd say, just remove the lines for now. Then I'll merge your changes. Thanks again!
Done.
Thank you!
Thanks @kuczek, yes this should totally be merged. If you would, please modify .travis.yml to test for these different Symfony versions - that would make sure we break nothing. Please check https://github.com/matthiasnoback/SymfonyDependencyInjectionTest/blob/master/.travis.yml to see how it' s done.