search

matthiasnoback / microsoft-translator

PHP library for making calls to the Microsoft Translator V3 API
MIT License
39 stars 26 forks source link

Added Azure Token Provider #17

Closed arraintxo closed 7 years ago

arraintxo commented 7 years ago

As Microsoft DataMarket services are being deprecated, an upgrade to Azure keys is needed. This pull request provides a new Azure Token Provider that easies this transition.

matthiasnoback commented 7 years ago

I'm sorry, missed this PR. I'm not actively maintaining this library to be honest. Would you by chance be interested in taking this role?

arraintxo commented 7 years ago

I'm using it on an active project, if new changes or bugfixes are needed I should take care of them, so I wouldn't mind trying to take the role.

matthiasnoback commented 7 years ago

Excellent! I'll give you GitHub permissions to work on it right-away. You could start with merging your own PR. Are you familiar with package maintenance? Like tagging, semantic versioning, etc.? I'd be happy to help out with any question you may have.

arraintxo commented 7 years ago

I have some knowledge about it, I know how tagging and semantic versioning work, but have no real world experience on package maintenance.

I will do it as well as I can :)

matthiasnoback commented 7 years ago

That's great! Best of luck then :)