Add dictionary lookup - Githubissues

matthiasnoback / microsoft-translator

PHP library for making calls to the Microsoft Translator V3 API

MIT License

39 stars 26 forks source link

Add dictionary lookup #25

Closed bjmrey closed 3 years ago

bjmrey commented 3 years ago

Microsoft Translator 3.0 includes a dictionary lookup API. This PR adds it.

arraintxo commented 3 years ago

Hi @bjmrey ,

Thanks for your PR.

Sadly I'll not be able to take a deeper look to this on a pair of weeks, but I have seen some work to be done before we can release a new version with this functionallity.

The tasks that may help for a faster merge are:

Remove unused $contentType and $category references from the MicrosoftTranslator::dictionaryLookup method docblock
Add tests for this new functionality.

arraintxo commented 3 years ago

I merged this and will make needed change to release it with the new version. Thanks for your contribution

bjmrey commented 3 years ago

Thanks a lot @arraintxo! Sorry I didn't find the time to respond earlier.