PHP v 8.x issue - Githubissues

matthiasnoback / microsoft-translator

PHP library for making calls to the Microsoft Translator V3 API

MIT License

39 stars 26 forks source link

PHP v 8.x issue #26

Closed sscotti closed 3 years ago

sscotti commented 3 years ago

Trying to update my packages and wondering how to resolve this:

Problem 1

kriswallsmith/buzz v0.16.1 requires php ^5.4 || ^7.0 -> your php version (8.0.9) does not satisfy that requirement.
matthiasnoback/microsoft-translator dev-master requires kriswallsmith/buzz ^0.16.1 -> satisfiable by kriswallsmith/buzz[v0.16.1].
Root composer.json requires matthiasnoback/microsoft-translator dev-master -> satisfiable by matthiasnoback/microsoft-translator[dev-master].

saschati commented 3 years ago

Maybe need to create a fork?

sscotti commented 3 years ago

Maybe. I frankly don't use the package that much anymore, but it would be nice to have it be compatible with php version 8.

arraintxo commented 3 years ago

Sorry for the delay, I've been busy the last month and didn't realize about this issue. But I will sure take a look to this.

arraintxo commented 3 years ago

I started working on this.

You can see some advancements on php8 branch if you want: https://github.com/matthiasnoback/microsoft-translator/tree/php8

Everything seems to work properly as far as we don't use cache functionality. I will try to fix that ASAP too.

There are some bc breaks as Buzz browser has changed a lot from 0.16 version (as expected). I guess we'll also have to release a new major version after everything is working.

arraintxo commented 3 years ago

I have just released v4.0-beta version with PHP8.0 support. Hope everything works OK.

Take into account Cache and Buzz browser related changes while upgrading.