search

matthiasnoback / microsoft-translator

PHP library for making calls to the Microsoft Translator V3 API
MIT License
39 stars 26 forks source link

`GetTranslations` #5

Closed paazmaya closed 10 years ago

paazmaya commented 10 years ago

Adds method GetTranslations, thus fixes #3

matthiasnoback commented 10 years ago

Awesome, I'll review it this weekend!

matthiasnoback commented 10 years ago

This looks very good, the tests are also running well. One remaining issue:

Not every element of TranslateOptions is supported by this, only category. I'd say we either remove support for category or we implement the other options too. This might require introduction a TranslateOptions value object, which can be provided as a constructor argument of a GetTranslations object.

Also I will add a few comments about formatting.

matthiasnoback commented 10 years ago

One last comment: it would be nice to mention this new feature in the README.md file too.

matthiasnoback commented 10 years ago

Sorry, I didn't get a notification of the changes you made. There are some things left to do, though I can help too. Just let me know what your plans are.

paazmaya commented 10 years ago

Hi, equally I did not seem to get a notification of your comment, already 4 days ago.

Anyhow I am slowly moving forward, so in case you have a moment, feel free to make changes as you see fit.

matthiasnoback commented 10 years ago

@paazmaya Thanks for your work! I changed some more things and released a new version (0.3.0).

paazmaya commented 10 years ago

Thank you!

matthiasnoback commented 10 years ago

You're welcome :)