search

matthiaszimmermann / bitcoin-paper-wallet

Bitcoin Paper Wallet Generator
Apache License 2.0
7 stars 2 forks source link

Segwit support #2

Open ghost opened 6 years ago

ghost commented 6 years ago

Any chance of adding segwit support? Segwit support was merged into bitcoinj master since july 2017: https://github.com/bitcoinj/bitcoinj/pull/1334

matthiaszimmermann commented 6 years ago

need to look into this. not even sure if/how offline accounts are affected by segwit. do you know more?

ghost commented 6 years ago

I didn't see any docs on the official bitcoinj site. Maybe the unit tests might be useful: https://github.com/bitcoinj/bitcoinj/blob/master/core/src/test/java/org/bitcoinj/core/AddressTest.java#L178

matthiaszimmermann commented 6 years ago

tx for the pointer. on my side i did find some comment on bitcointalk [1]. i think i'll need more time to figure things out ...

[1] https://bitcointalk.org/index.php?topic=2145219.0

jonathancross commented 6 years ago

This might be helpful: https://bitcoincore.org/en/segwit_wallet_dev/ - although it is a little out of date and doesn't have current info about BIP173 Bech32 encoding of P2WPKH and P2WSH.

Edit: I just sent a PR to update the doc: https://github.com/bitcoin-core/bitcoincore.org/pull/515