search

matthieugomez / LeastSquaresOptim.jl

Dense and Sparse Least Squares Optimization
Other
53 stars 16 forks source link

Warning about type `T` declared but not used #34

Closed GlenHertz closed 1 year ago

GlenHertz commented 1 year ago

Perhaps minor issue, I get the warning:

WARNING: method definition for mul! at .../LeastSquaresOptim/B1WKJ/src/solver/iterative_lsmr.jl:87 declares type variable T but does not use it.

When using a package that depends on this package.

GlenHertz commented 1 year ago

Is there a reason to have this unused type: https://github.com/matthieugomez/LeastSquaresOptim.jl/blob/c8dc7f7c1f0d4e4fcae215be0b7e385ffcfd81c4/src/solver/iterative_lsmr.jl#L87

matthieugomez commented 1 year ago

Thanks! Should be fixed now.