search

matthieugrieger / mumbledj

A Mumble bot that plays audio fetched from various media sites.
MIT License
170 stars 59 forks source link

!move feature #142

Closed azlux closed 8 years ago

azlux commented 8 years ago

hi, I'm think about a new feature. Instead of !move <channel/sub-channel...> can be possible to have a command !joinme where the bot join the channel where you are ?

Thank a lot for the bot, it's awesome !

Az

matthieugrieger commented 8 years ago

Good idea! Currently the bot only scans comments in the channel it is currently residing in, so it is possible that this would not be possible.

However, if it was a private message to MumbleDJ it would most likely work across channels.

I'll take a look at it as soon as I can.

azlux commented 8 years ago

Indeed, I was thinking about private message. ( I'm trying to make a mumo script to do that when the message is in the user channel, but the doc is missing) It's will be mode user-friendly than !move chanel/subchannels command

azlux commented 8 years ago

Done it, I will pull the code this evening. I took the command !joinme Working so good

azlux commented 8 years ago

did I fork/pull your master or refractor ? what do you prefer ?

matthieugrieger commented 8 years ago

Nice! Master would be great. I'm not sure what the ETA for the refactor branch being merged into master is. I'll simply incorporate your changes in the refactor branch later.

matthieugrieger commented 8 years ago

This feature has been implemented by @azlux. Thanks again!