Allow playlists larger than 50 items

mattikus commented 8 years ago

Before submitting this pull request, please acknowledge that you have done the following:

[x] I have tested my changes to make sure that they work
[ ] I have at least attempted to write relevant unit tests to verify that my changes work
[x] I have read through the contribution guidelines
[x] I have written any necessary documentation (for example, adding information about a feature to the README)

What type of pull request is this?

[x] Bug fix
[ ] Typo fix
[ ] New feature implementation
[ ] New service implementation
[ ] Other

Description of your pull request:

This commit ensures that playlists longer than 50 items return successfully when max_tracks_per_playlist is set higher than 50.

Previously if this value was raised higher than 50 the addition of a playlist with more than 50 items would hang indefinitely.

mattikus commented 8 years ago

I would have attempted to add a test but there don't seem to be any YouTube tests at the moment and I figured this might be somewhat hard to test.

codecov-io commented 8 years ago

Current coverage is 46.80%

Merging #159 into master will not change coverage

@@             master       #159   diff @@
==========================================
  Files            35         35          
  Lines          1220       1220          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            571        571          
  Misses          646        646          
  Partials          3          3

Powered by Codecov. Last updated by 8c61ca2...534620b

matthieugrieger commented 8 years ago

Good catch, thanks for the bug fix! Don't worry about the unit tests.

Merged!

matthieugrieger / mumbledj