matthijskooijman / arduino-lmic

:warning: This library is deprecated, see the README for alternatives.
710 stars 650 forks source link

ADR not working #96

Open LiamDoumen opened 7 years ago

LiamDoumen commented 7 years ago

Hi,

I'm working on ADR in a ABP example project. When setting the ADR to 1, The device starts sending at SF12. It won't change SF even though the RSSI is around +10 dB. This is my code, any thoughs?

include

include <hal/hal.h>

include <lmic/lorabase.h>

include // use 2 for interrupt/digital input, use A0 for analog, use 0 for not in use

define DATA_PIN_ONE 7

define DATA_PIN_TWO 0

define CONFIRMED 0 //Indicate wether packets are send confirmed (1) or unconfirmed (0)

define CR CR_4_5 //Coding Rate: CR_4_5, CR_4_6, CR_4_7 or CR_4_8

define SF DR_SF7 //Spread Factor (sending) : DR_FSK, DR_SF7B, DR_SF7, DR_SF8, DR_SF9, DR_SF10, DR_SF11, DR_SF12 NOT USED WHEN ADR is on

define ADR_MODE 1 //Adaptive Data Rate: 1 = on, 0 = off

// LoRaWAN NwkSKey, network session key // This is the default Semtech key, which is used by the early prototype TTN // network. static const PROGMEM u1_t NWKSKEY[16] = { 0xD7, 0x3B, 0x3F, 0xA1, 0x45, 0x6C, 0xED, 0x1A, 0x86, 0xD6, 0x4D, 0xD5, 0xB9, 0x61, 0x97, 0x9D};

// LoRaWAN AppSKey, application session key // This is the default Semtech key, which is used by the early prototype TTN // network. static const u1_t PROGMEM APPSKEY[16] = { 0xB3, 0x1F, 0xC5, 0x26, 0x3C, 0x66, 0xBC, 0xDC, 0x09, 0xA4, 0x3A, 0xD3, 0xCD, 0x6F, 0x33, 0xAB};

// LoRaWAN end-device address (DevAddr) static const u4_t DEVADDR = 0x00000001 ; // <-- Change this address for every node!

// These callbacks are only used in over-the-air activation, so they are // left empty here (we cannot leave them out completely unless // DISABLE_JOIN is set in config.h, otherwise the linker will complain). void os_getArtEui (u1_t buf) { } void os_getDevEui (u1_t buf) { } void os_getDevKey (u1_t* buf) { }

static osjob_t sendjob;

// Schedule TX every this many seconds (might become longer due to duty // cycle limitations). const unsigned TX_INTERVAL = 5*60;

// Pin mapping const lmic_pinmap lmic_pins = { .nss = 8, .rxtx = LMIC_UNUSED_PIN, .rst = 0, .dio = {5,4,3}, };

void onEvent (ev_t ev) { Serial.print(os_getTime()); Serial.print(": "); switch(ev) { case EV_SCAN_TIMEOUT: Serial.println(F("EV_SCAN_TIMEOUT")); break; case EV_BEACON_FOUND: Serial.println(F("EV_BEACON_FOUND")); break; case EV_BEACON_MISSED: Serial.println(F("EV_BEACON_MISSED")); break; case EV_BEACON_TRACKED: Serial.println(F("EV_BEACON_TRACKED")); break; case EV_JOINING: Serial.println(F("EV_JOINING")); break; case EV_JOINED: Serial.println(F("EV_JOINED")); break; case EV_RFU1: Serial.println(F("EV_RFU1")); break; case EV_JOIN_FAILED: Serial.println(F("EV_JOIN_FAILED")); break; case EV_REJOIN_FAILED: Serial.println(F("EV_REJOIN_FAILED")); break; case EV_TXCOMPLETE: Serial.println(F("EV_TXCOMPLETE (includes waiting for RX windows)")); if (LMIC.txrxFlags & TXRX_ACK) Serial.println(F("Received ack")); if (LMIC.dataLen) { Serial.println(F("Received ")); Serial.println(LMIC.dataLen); Serial.println(F(" bytes of payload")); } // Schedule next transmission os_setTimedCallback(&sendjob, os_getTime()+sec2osticks(TX_INTERVAL), do_send);

        break;
    case EV_LOST_TSYNC:
        Serial.println(F("EV_LOST_TSYNC"));
        break;
    case EV_RESET:
        Serial.println(F("EV_RESET"));
        break;
    case EV_RXCOMPLETE:
        // data received in ping slot
        Serial.println(F("EV_RXCOMPLETE"));
        break;
    case EV_LINK_DEAD:
        Serial.println(F("EV_LINK_DEAD"));
        break;
    case EV_LINK_ALIVE:
        Serial.println(F("EV_LINK_ALIVE"));
        break;
     default:
        Serial.println(F("Unknown event"));
        break;
}

}

void do_send(osjob_t j){ float sens; int i; String string_buffer; uint8_t buf[10]; // Check if there is not a current TX/RX job running if (LMIC.opmode & OP_TXRXPEND) { Serial.println(F("OP_TXRXPEND, not sending")); } else { string_buffer = "ProtoSX"; /String(sens);*/ Serial.print(string_buffer); uint8_t strlength = string_buffer.length(); string_buffer.toCharArray(buf, strlength+1); // Prepare upstream data transmission at the next possible time. LMIC_setTxData2(1, buf, strlength, CONFIRMED);

    Serial.println(F("Packet queued"));
}
// Next TX is scheduled after TX_COMPLETE event.

}

void setup() { uint8_t i; Serial.begin(115200); Serial.println(F("Starting"));

#ifdef VCC_ENABLE
// For Pinoccio Scout boards
pinMode(VCC_ENABLE, OUTPUT);
digitalWrite(VCC_ENABLE, HIGH);
delay(1000);
#endif

// LMIC init
os_init();
// Reset the MAC state. Session and pending data transfers will be discarded.
LMIC_reset();

// Set static session parameters. Instead of dynamically establishing a session
// by joining the network, precomputed session parameters are be provided.
#ifdef PROGMEM
// On AVR, these values are stored in flash and only copied to RAM
// once. Copy them to a temporary buffer here, LMIC_setSession will
// copy them into a buffer of its own again.
uint8_t appskey[sizeof(APPSKEY)];
uint8_t nwkskey[sizeof(NWKSKEY)];
memcpy_P(appskey, APPSKEY, sizeof(APPSKEY));
memcpy_P(nwkskey, NWKSKEY, sizeof(NWKSKEY));
LMIC_setSession (0x1, DEVADDR, nwkskey, appskey);
#else
// If not running an AVR with PROGMEM, just use the arrays directly
LMIC_setSession (0x1, DEVADDR, NWKSKEY, APPSKEY);
#endif

#if defined(CFG_eu868)
// Set up the channels used by the Things Network, which corresponds
// to the defaults of most gateways. Without this, only three base
// channels from the LoRaWAN specification are used, which certainly
// works, so it is good for debugging, but can overload those
// frequencies, so be sure to configure the full frequency range of
// your network here (unless your network autoconfigures them).
// Setting up channels should happen after LMIC_setSession, as that
// configures the minimal channel set.
// NA-US channels 0-71 are configured automatically
LMIC_setupChannel(0, 868100000, DR_RANGE_MAP(DR_SF11, DR_SF7),  BAND_CENTI);      // g-band
LMIC_setupChannel(1, 868300000, DR_RANGE_MAP(DR_SF11, DR_SF7), BAND_CENTI);      // g-band
LMIC_setupChannel(2, 868500000, DR_RANGE_MAP(DR_SF11, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(3, 867100000, DR_RANGE_MAP(DR_SF12, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(4, 867300000, DR_RANGE_MAP(DR_SF12, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(5, 867500000, DR_RANGE_MAP(DR_SF12, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(6, 867700000, DR_RANGE_MAP(DR_SF12, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(7, 867900000, DR_RANGE_MAP(DR_SF12, DR_SF7),  BAND_CENTI);      // g-band
//LMIC_setupChannel(8, 868800000, DR_RANGE_MAP(DR_FSK,  DR_FSK),  BAND_MILLI);      // g2-band
// TTN defines an additional channel at 869.525Mhz using SF9 for class B
// devices' ping slots. LMIC does not have an easy way to define set this
// frequency and support for class B is spotty and untested, so this
// frequency is not configured here.
#elif defined(CFG_us915)
// NA-US channels 0-71 are configured automatically
// but only one group of 8 should (a subband) should be active
// TTN recommends the second sub band, 1 in a zero based count.
// https://github.com/TheThingsNetwork/gateway-conf/blob/master/US-global_conf.json
LMIC_selectSubBand(1);
#endif

// Disable link check validation
LMIC_setAdrMode(ADR_MODE);
LMIC_setLinkCheckMode(0);
LMIC_disableTracking ();
LMIC_stopPingable();
//TTN uses SF9 for its RX2 window.
LMIC.dn2Dr = DR_SF9;
if(ADR_MODE != 1){
  LMIC_setDrTxpow(SF,14);      
}
// Set data rate and transmit power for uplink (note: txpow seems to be ignored by the library)
// Start job
do_send(&sendjob);

}

void loop() { os_runloop_once(); }

Erik-Koning commented 5 years ago

@LiamDoumen Any updates on this?

martinius96 commented 12 months ago

after 4 years something?

trlafleur commented 12 months ago

There are a number of complete LoRa radio that support AT commands that are very easy to use, cost less than RFM 95, with complete LoRa stack inside. Look at Seeed E5 and others

LMiC is Obsolete! Or should be!

On Mon, Oct 23, 2023 at 5:37 PM Martin Chlebovec @.***> wrote:

after 4 years something?

— Reply to this email directly, view it on GitHub https://github.com/matthijskooijman/arduino-lmic/issues/96#issuecomment-1776061428, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABC4EK2ARNGNRMP6DVMOF63YA3PQ7AVCNFSM4DK32K5KU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZXGYYDMMJUGI4A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

matthijskooijman commented 12 months ago

LMiC is Obsolete! Or should be!

At least this version of it is no longer maintained, see the README for other recommendations.