matthijsvrenswoude / IframeJellySeerr

Iframe jellySeerr in JellyFin
1 stars 0 forks source link

Recommendations #1

Open Bretterteig opened 1 week ago

Bretterteig commented 1 week ago

Hey @matthijsvrenswoude,

great idea. Was looking for something like this. Might want to look into building a plugin for adding IFrames in general?

Here are some suggestions that might proof useful:

  1. Instead of altering the jellyseerr skin manually you could use the dark skin from the guys over at theme.park: The dark skin matches the dark skin of Jellyfin perfectly and is compatible with jellyseerr.
  2. Maybe build a plugin out of it and use inject login like used in Intro Skipper
  3. The .js is not compatible with Jellyfin 10.9.6. Instead of appRouter I changed it to LibraryMenu
  4. Use a translated string for the tab. Something like Browse, Download, LabelSource or MediaInfoExternal
  5. I altered the Jellyfin custom css to the following, which I found to be more responsive.
    #requestMediaTab {
    height: 100%;
    }
    #indexPage:has(#requestMediaTab.is-active) {
    padding-bottom: 0em !important;
    overflow: hidden;
    }
    @media (min-width: 100em) {
    #indexPage:has(#requestMediaTab.is-active) {
        padding-top: 4.3em !important;
    }
    }
    @media (max-width: 100em) {
    #indexPage:has(#requestMediaTab.is-active) {
        padding-top: 7.3em !important;
    }
    }
matthijsvrenswoude commented 1 week ago

Hi @Bretterteig,

I'll have to look into your suggestions. I currently only made this project for myself, and uploaded it in case anyone want to work on this for them self and use it as some kind of reference material. Which explains the more unpolished nature. However, if needed ill gladly rebuild it into a plugin, which from your example that you have shown isn't the most difficult thing to do.

  1. On my jellyfin setup I use JellySkin which is skin that I quite like. However, since there is no similar looking equivalent for jellyseerr, I kinda ported the style over to jellyseerr by custom CSS. If I did it properly, I would add multiple style options and submit some pull requests to jellyseerr source code with custom CSS field additions, hoping it would be approved. Rebuilding it into a plugin would also make it more resilient for updates.

  2. I know, I have looked into the changes of 10.9.x. I already had my mind on upgrading the code for the jellyseerr/jellyfin “glue” however having tried twice I found 10.9.x not to be as stable as 10.8.13. Even though I can handle some bugs. My primary display is an LG CX Oled which after the update doesn't handle Dolby Vision well anymore, which for me is a total dealbreaker. So currently I won't upgrade until that issue is resolved.

I am however currently working on my media processing tools to maybe speed up this transition. I already have a few Tdarr plugins that do quite a lot of manipulation to media files. For example removing unused audio tracks in languages that I don't speak, remove unused codecs, commentary tracks and more, basically do anything for saving GB's without sacrificing image or audio quality. I also have a plugin for converting Dolby Vision profile 7 media to Dolby Vision 8, which can be displayed properly on my TV. I used a few of these created plugins for the last couple of months and have thrown my entire movie collection to it, and it holds up well. However, doing it all separately is first of inefficient and makes it quite prone to failure, so rewriting all the plugins in 1 super media processing plugin, with the focus on supporting Dolby Vision is currently on my agenda.

Progress you can follow here: https://github.com/matthijsvrenswoude/Tdarr_Plugin-engine If you would like to use it, I would suggest using the last commit from May 27th.