search

matthiku / cSpot

c-SPOT - the church-Services Planning Online Tool
5 stars 4 forks source link

Adding CI build pipeline with Github Action #204

Closed chris24walsh closed 4 years ago

chris24walsh commented 4 years ago

Sorry about the mess :) I pushed the first few commits directly to master, then decided I should open a PR instead to keep track of this new CI/CD work.

matthiku commented 4 years ago

No worries. Go ahead and merge. Btw.,the reason why I don't use Docker myself is that it is in conflict with my VirtualBox and also because I use Laravel, which allows me to use https and a customer URL for local testing.

chris24walsh commented 4 years ago

@matthiku I've encountered installation dependency issues before, and again now with your latest commits. So I'd like to introduce this CI/CD pipeline so we can be on the same page, and identify immediately any more dependency issues. With regard to your reasons against Docker, I'm not sure I understand. Wouldn't it be straightforward to do that also with containers?

chris24walsh commented 4 years ago

Btw, let's not merge this PR until it is at least passing the github action that it is introducing! :)

matthiku commented 4 years ago

Probably. It's just easier for me but then I don't know enough about Docker/containers. Care of having a quick video call e.g. on Jitsi.org to discuss this?

chris24walsh commented 4 years ago

Yeah, that would be great! How about 17:10? Also, I'm not stuck on Docker, but I do think it would be best to nail down the build in a pipeline like this, since it makes it much easier to colaborate.

matthiku commented 4 years ago

I'll send an invite for that meeting. Is your gmail address still working? (chris24....)

chris24walsh commented 4 years ago

Yep, I have the details from your previous mail on Wednesday. Sorry for not replying yet :)