search

matthiku / cSpot

c-SPOT - the church-Services Planning Online Tool
5 stars 4 forks source link

Integrate ci to laravael 5.8 #208

Closed chris24walsh closed 4 years ago

chris24walsh commented 4 years ago

I have deleted the other PRs, since they were misleading and unhelpful in intent. The PR-triggered workflow was running on a merged-to-master commit, which was doomed to fail without upgrades to the dockerfile (I think). This PR is to integrate a new CI workflow to a known working version of laravel, version 5.8 - I've made a branch based on the commit where laravel was updated to 5.8. From there, we can begin a second PR to integrate this CI workflow with the newest version, 6.0.

chris24walsh commented 4 years ago

Great, now we can see that the build passes. So the CI workflow is working, and showing a successful build of the cSpot application stack, as defined by the Dockerfile. Now we can merge new code, while always having assurance the project is fully buildable from scratch for any colloborators/users without any invisible dependencies! :)

chris24walsh commented 4 years ago

Oops, closed instead of merging - now merged.