search

matthojo / videojs-Background

Allows for videos to be displayed as a full background to any element.
MIT License
77 stars 41 forks source link

Version bump. #14

Closed IngoValente closed 8 years ago

IngoValente commented 8 years ago

Adds support for video.js v5 in the npm version.

Should also maybe consider removing video.js from devDependencies & dependencies in package.json, as peerDependency only should be sufficient?

matthojo commented 8 years ago

Thank you for your PR. This only appears to update the package.json version for this repo though :)

IngoValente commented 8 years ago

Ah yes forgot about bower. Also added it to the build files, like you did in the previous bump. Should be ok now, or am I missing something?

matthojo commented 8 years ago

All good! Thanks.

IngoValente commented 8 years ago

Oops, seems like it broke the npm package. Somehow when I install it now, the dist folder is not included, and thus it doesn't find the main file. Any idea why?

matthojo commented 8 years ago

How are you installing it, via npm?

IngoValente commented 8 years ago

Yes just running npm install videojs-background. Weird thing is that the bower files are correctly ignored and not downloaded.

A solution would be to change the npm main file to point to the lib folder, and let the dist folder be for the bower users.

matthojo commented 8 years ago

What version of npm are you using?

IngoValente commented 8 years ago

Ah yes that could be it. I'm using 3.3.12, the package says 2.14.11. Before this commit it worked fine though?