search

matthojo / videojs-Background

Allows for videos to be displayed as a full background to any element.
MIT License
77 stars 41 forks source link

Window width vs element width #2

Closed niallobrien closed 7 years ago

niallobrien commented 9 years ago

There's an issue with lines 89 & 90 that relates to iOS. As the calculations are based off the window dimensions, this is not always ideal as when you scroll down on iOS, the Mobile Safari url bar shrinks in height, which affects the window dimensions, thus causing the image to adjust accordingly.

Simply removing the conditionals on those two lines resolves the issue, however I'm not sure how this may affect usage of this plugin under other circumstances for others.

var containerW = settings.container.clientWidth,
  containerH = settings.container.clientHeight,
niallobrien commented 7 years ago

@matthojo Any thoughts on the above, or should I close this issue for now? Thanks.

matthojo commented 7 years ago

@niallobrien We could close for now, thank you. I've not touched this project is too long! It probably needs a fairly decent refactor.